Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If a damage effect ignores armor, max out Pierce in its Damage Preview #1283

Merged
merged 1 commit into from
Oct 29, 2023
Merged

If a damage effect ignores armor, max out Pierce in its Damage Preview #1283

merged 1 commit into from
Oct 29, 2023

Conversation

Iridar
Copy link
Contributor

@Iridar Iridar commented Oct 29, 2023

Fixes #1281

@ps2guides
Implement Issue X2CommunityCore#1281 - if a damage effect ignores arm…
6c239f3 
…or, max out Pierce in its Damage Preview
@Iridar Iridar added this to the 1.27.0 milestone Oct 29, 2023
@Iridar Iridar self-assigned this Oct 29, 2023
@Iridar Iridar added the ready-to-review A pull request is ready to be reviewed label Oct 29, 2023
@Iridar Iridar merged commit 8c2a11e into X2CommunityCore:master Oct 29, 2023
4 checks passed
@Iridar Iridar deleted the 1281-pierce-ignore-armor branch October 29, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Iridar Iridar

Labels
bug-basegame ready-to-review A pull request is ready to be reviewed
Projects
None yet
Milestone
1.27.0
Development

Successfully merging this pull request may close these issues.

Inconsistency between bIgnoreArmor and high Pierce values
2 participants
@Iridar @ps2guides